[bug-gettext] [bug #49560] [PATCH] _nl_language_preferences_default needs updating for macOS Sierra (10.12)

[Kristian Rietveld]

URL:
  <http://savannah.gnu.org/bugs/?49560>

                 Summary: [PATCH] _nl_language_preferences_default needs
updating for macOS Sierra (10.12)
                 Project: GNU gettext
            Submitted by: krietvel
            Submitted on: Tue 08 Nov 2016 08:01:46 PM GMT
                Category: None
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

_nl_language_preferences_default() (in gettext-runtime/intl/langprefs.c) has a
special implementation for macOS. In this function all preferred languages as
configured in the Operating System are iterated. As soon as the English
language is detected, the iteration is stopped and no further languages are
considered. This is because many GNU programs don't ship an en.mo catalog.

The problem is that detection of the English language is no longer working
properly on macOS Sierra (10.12), causing preferred languages with a lower
priority than English to be considered. This problem has been reported
numerous times in the GIMP bug tracker (see
https://bugzilla.gnome.org/show_bug.cgi?id=770708).

The attached patch solves the problem. (Although the patch is not against the
most recent release of gettext, the code in git HEAD also shows this problem).


Before Sierra, preferred languages were listed as:

   en
   nl
   de
   es

Starting with Sierra, this has changed to:

   en-CA
   en-GB
   gd-CA
   hi-CA

which is way modification of the string comparison is required. This change is
elaborated in the following Apple TechNote:
https://developer.apple.com/library/content/technotes/tn2418/_index.html






    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Tue 08 Nov 2016 08:01:46 PM GMT  Name:
gettext-fix-English-language-fallback-for-macOS-Sierra.patch  Size: 1kB   By:
krietvel
Proposed patch
<http://savannah.gnu.org/bugs/download.php?file_id=38908>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?49560>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/