Re: [PATCH] gtags-cscope -C (ignore case) can't find definitions

[Shigio YAMAGUCHI]

Hi,
I have committed your patch to the repository.
The next release will include the fix.

Thank you for your report and fix!

> When using gtags-cscope with the -C argument to ignore case, it passes
> malformed arguments to global which prevents it from looking up the
> definition points of the requested identifier.
> 
> Given bug.c:
> ------------
> #define FOO 12
> int main(int argc, const char *argv[]) {
>     return FOO;
> }
> 
> Repro:
> ------
> $ gtags-cscope -Cv
> 
> Expected:
> ---------
> >> 1foo
> gscope: /usr/local/bin/global --result=cscope --ignore-case 'foo'
> cscope: 1 lines
> bug.c FOO 1 #define FOO 12
> 
> We get:
> -------
> >> 1foo
> gscope: /usr/local/bin/global --result=cscope -
> cscope: 0 lines
> 
> 
> The problem is in execute_command() -- when the opt argument is 0 it
> adds a bad "-\0" commandline option to the command strbuf which
> null-terminates it.  The attached patch corrects and simplifies this
> logic.
> 
> It looks like I just missed a release with this; sorry!  Please consider
> the patch for the next release.
> 
> Thanks,
> Steve
--
Shigio YAMAGUCHI <address@hidden>
PGP fingerprint: D1CB 0B89 B346 4AB6 5663  C4B6 3CA5 BBB3 57BE DDA3