[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#4448: 23.1; unrmail fails if buffer has mixed line endings (patch)
From: |
Eli Zaretskii |
Subject: |
bug#4448: 23.1; unrmail fails if buffer has mixed line endings (patch) |
Date: |
Wed, 16 Sep 2009 20:17:38 +0300 |
> Date: Wed, 16 Sep 2009 09:28:35 -0400
> From: "David J. Biesack" <David.Biesack@sas.com>
> Cc:
>
>
> I invoked rmail-input on an RMAIL file and got the following traceback.
>
> I performed find-file-literally on the rmail file and found that
> it has mixed line endings - text text of the first messages end in just LF and
> others end in CR LF. This causes the
>
> (re-search-forward "^[*][*][*] EOOH [*][*][*]\n")
>
> in unrmail to fail.
Yes, by design (although the traceback is not by design).
> Here is a patch which makes it work, but I don't think this is the correct
> change; it seems that the correct change would be to account for coding
> systems.
Actually, I think the correct change would be to throw an error with a
meaningful error message. Babyl files written by Rmail are supposed
to have Unix EOLs. Of course, entering the debugger is not a graceful
reaction, but I don't think we should support incorrectly formatted
Babyl files. That way lies madness.
Thanks.