[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#4381: 23.1.50; Cocoa Emacs: face background for 'region set in ns-wi
From: |
Stefan Monnier |
Subject: |
bug#4381: 23.1.50; Cocoa Emacs: face background for 'region set in ns-win.el after .emacs |
Date: |
Thu, 24 Sep 2009 13:35:03 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) |
>>> --- faces.el.~1.446.~ 2009-09-05 15:33:48.000000000 -0400
>>> +++ faces.el 2009-09-23 23:06:19.000000000 -0400
>>> @@ -2281,6 +2281,8 @@ terminal type to a different value."
>>> (defface region
>>> '((((class color) (min-colors 88) (background dark))
>>> :background "blue3")
>>> + (((class color) (min-colors 88) (background light) (type ns))
>>> + :background "ns_selection_color")
>>> (((class color) (min-colors 88) (background light))
>>> :background "lightgoldenrod2")
>>> (((class color) (min-colors 16) (background dark))
>>
>> Could you add a comment explaining why you put (background light) in
>> the specs? I guess it's because the ns_selection_color is (almost)
>> always defined with the assumption that it will be used on text
>> displayed on a light background., right?
> Something like:
> ;; Region face: under NS, use the system-defined selection color
> ;; (optimized for the system-fixed white background of other apps),
> ;; if background is light.
Looks good, please install it,
Stefan
- bug#4381: 23.1.50; Cocoa Emacs: face background for 'region set in ns-win.el after .emacs, (continued)
- bug#4381: marked as done (23.1.50; Cocoa Emacs: face background for 'region set in ns-win.el after .emacs), Emacs bug Tracking System, 2009/09/27
- bug#4381: 23.1.50; Cocoa Emacs: face background for 'region set in ns-win.el after .emacs, Adrian Robert, 2009/09/18
- bug#4381: 23.1.50; Cocoa Emacs: face background for 'region set in ns-win.el after .emacs, Erik Charlebois, 2009/09/19
- bug#4381: 23.1.50; Cocoa Emacs: face background for 'region set in ns-win.el after .emacs, Stefan Monnier, 2009/09/20
- bug#4381: 23.1.50; Cocoa Emacs: face background for 'region set in ns-win.el after .emacs, Adrian Robert, 2009/09/22
- bug#4381: 23.1.50; Cocoa Emacs: face background for 'region set in ns-win.el after .emacs, Stefan Monnier, 2009/09/23
- bug#4381: 23.1.50; Cocoa Emacs: face background for 'region set in ns-win.el after .emacs, Adrian Robert, 2009/09/23
- bug#4381: 23.1.50; Cocoa Emacs: face background for 'region set in ns-win.el after .emacs, Stefan Monnier, 2009/09/24
- bug#4381: 23.1.50; Cocoa Emacs: face background for 'region set in ns-win.el after .emacs, Adrian Robert, 2009/09/24
- bug#4381: 23.1.50; Cocoa Emacs: face background for 'region set in ns-win.el after .emacs,
Stefan Monnier <=