[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#27953: vc-region-history doesn't follow renames
From: |
Clément Pit--Claudel |
Subject: |
bug#27953: vc-region-history doesn't follow renames |
Date: |
Sat, 5 Aug 2017 15:06:00 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 2017-08-04 19:21, Stefan Monnier wrote:
>> Indeed, `git log -p --follow -L5,25:file.c' doesn't work. But `git
>> log -p --follow -L5,25:file.c file.c' does work (note the extra mention of
>> the file name).
>
> Hmm... what's the difference between
>
> git log -p -L5,25:file.c
> and
> git log -p -L5,25:file.c file.c
The second one allows --follow; the first one doesn't. I don't know what
differences they may be beyond that :/
> Would this issue deserve a bug-report to Git?
Possibly; it's a bit intimidating.
>> Any arguments against the attached patch?
>
> I'd suggest to compute (file-relative-name file) only once, and to add
> bug#27953 to the comment, but otherwise, looks good.
Attached an updated version :)
Clément.
0001-Follow-renames-in-vc-git-region-history.patch
Description: Text Data
signature.asc
Description: OpenPGP digital signature
- bug#27953: vc-region-history doesn't follow renames, Clément Pit--Claudel, 2017/08/04
- bug#27953: vc-region-history doesn't follow renames, Stefan Monnier, 2017/08/04
- bug#27953: vc-region-history doesn't follow renames, Andreas Schwab, 2017/08/04
- bug#27953: vc-region-history doesn't follow renames,
Clément Pit--Claudel <=
- bug#27953: vc-region-history doesn't follow renames, Kyle Meyer, 2017/08/05
- bug#27953: vc-region-history doesn't follow renames, Eli Zaretskii, 2017/08/05
- bug#27953: vc-region-history doesn't follow renames, Andreas Schwab, 2017/08/05
- bug#27953: vc-region-history doesn't follow renames, Eli Zaretskii, 2017/08/05
- bug#27953: vc-region-history doesn't follow renames, Kyle Meyer, 2017/08/05
- bug#27953: vc-region-history doesn't follow renames, Clément Pit--Claudel, 2017/08/05
- bug#27953: vc-region-history doesn't follow renames, Kyle Meyer, 2017/08/05
- bug#27953: vc-region-history doesn't follow renames, Andreas Schwab, 2017/08/05