bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#35916: [PATCH] checkdoc fixes in bookmark.el


From: Eli Zaretskii
Subject: bug#35916: [PATCH] checkdoc fixes in bookmark.el
Date: Sat, 08 Jun 2019 11:37:42 +0300

> From: Stefan Kangas <stefan@marxist.se>
> Date: Thu, 30 May 2019 19:53:58 +0200
> Cc: 35916@debbugs.gnu.org
> 
> Please find attached an updated version of the patch with an improved commit
> message.

Thanks, this is OK, with one comment:

>  (defun bookmark-bmenu-other-window-with-mouse (event)
> -  "Select bookmark at the mouse pointer in other window, leaving bookmark 
> menu visible."
> +  "Select bookmark at the mouse pointer in other window.
> +Move point to the position of EVENT, and leave bookmark menu
> +visible."

The first line of the doc string should mention the arguments, in this
case EVENT.  Could you please rework this hunk and resubmit the patch?





reply via email to

[Prev in Thread] Current Thread [Next in Thread]