[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#35564: [PATCH v2] Tweak dired warning about "wildcard" characters
From: |
Kévin Le Gouguec |
Subject: |
bug#35564: [PATCH v2] Tweak dired warning about "wildcard" characters |
Date: |
Sun, 09 Jun 2019 13:08:41 +0200 |
Hello,
Here is my second attempt at solving this issue.
To recap: dired-do-shell-command warns the user about non-isolated '*'
and '?' characters since the function will not substitute them. It
refers to these characters as "wildcards", which can be incorrect: they
may be quoted or backslash-escaped, in which case the shell will not
interpret them as wildcards.
My main motivation to change this warning is that it trips my brain to
have to answer "yes" ("yes, I want to use wildcards") when no wildcards
are involved.
I could not come up with a simple, self-sufficient rephrasing for the
warning, so I decided to display the command itself as part of the
warning prompt, highlighting the non-isolated characters.
The first patch adjusts y-or-n-p so that it preserves the prompt's text
properties. The second patch changes dired-do-shell-command's prompt.
0001-Preserve-text-properties-in-y-or-n-p-prompts.patch
Description: Text Data
0002-Tweak-dired-warning-about-wildcard-characters.patch
Description: Text Data
Sample screenshot:
dired-warning-highlight.png
Description: PNG image
I am not sure these patches should be applied as-is. Some things I
wonder about:
1. About read--propertize-prompt…
1. Should the function return a copy of its argument instead of
propertizing it directly?
2. Is it properly named? Does it fit in subr.el? I placed it there
because I figured other users of read-char in subr.el could use
it, e.g. read-char-choice.
2. dired-aux.el already contains some logic to detect isolated
characters; I could not think of a way to re-use it, so I added my
own functions to find *non*-isolated characters. I added unit tests
for these new functions; still, there may be some redundancy there.
WDYT?
PS1: I am still absolutely open to simply rephrasing the prompt… I just
cannot come up with good alternatives.
PS2: CC'ing Stefan to follow up on the discussion on emacs-devel.
<https://lists.gnu.org/archive/html/emacs-devel/2019-05/msg00339.html>
- bug#35564: [PATCH v2] Tweak dired warning about "wildcard" characters,
Kévin Le Gouguec <=
bug#35564: [PATCH v3] Tweak dired warning about "wildcard" characters, Kévin Le Gouguec, 2019/06/26