bug#36159: [PATCH] auto-revert mode doesn't work when changing buffer file name

[Mattias Engdegård]

11 juni 2019 kl. 15.15 skrev Michael Albinus <michael.albinus@gmx.de>:
> 
>> +(defun auto-revert--set-visited-file-name ()
> 
> Since we add it to a hook from another package, it shouldn't be marked
> internal. Call it `auto-revert-set-visited-file-name'.

Done. I actually wanted to add a buffer-local hook, but it turns out that 
`after-set-visited-file-name-hook', as written, wouldn't work for local hooks 
-- the very action of `set-visited-file-name' wipes out local hooks, no doubt 
for good reasons, before they can trigger.

> In the other tests, we separate the unwindforms from the bodyform (an
> empty line, plus a comment). Maybe you could do it here as well.

Done.
I also removed the binding of `auto-revert-avoid-polling' in the new test, 
since it isn't strictly necessary to exhibit the bug.

>   FAILED  auto-revert-test05-global-notify-remote
>   FAILED  auto-revert-test06-write-file-remote
> 
> Do you want to check, or shall I do it?

Oh, would you do that? I feel bad about causing test failures like this!
The first error may be from a recently committed (f2e4c34de6) fix of an earlier 
copy-paste mistake; sorry about that. I'm unsure how to deal with these errors 
myself; I have no inotifywait equivalent on this machine (macOS).

Thanks a lot for your help!

0001-Keep-auto-revert-mode-working-when-changing-buffer-f.patch
Description: Binary data