[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#25032: 25.1; `bookmark-set-internal', `bookmark-set-no-overwrite'
From: |
Stefan Kangas |
Subject: |
bug#25032: 25.1; `bookmark-set-internal', `bookmark-set-no-overwrite' |
Date: |
Wed, 12 Jun 2019 11:09:33 +0200 |
Drew Adams <drew.adams@oracle.com> writes:
> 1. Why is "internal" function `bookmark-set-internal' a _command_
> (interactive)? What sense does an "internal" command make? It seems
> that the `interactive' spec here was a copy+paste mistake. It should
> be removed, I think.
>
> 2. The `interactive' spec for `bookmark-set-internal' seems wrong
> anyway. NAME is the raw prefix arg? And then NAME is simply taken
> as is (as STR) and compared using `string-equal'? This cannot be
> correct.
This has now been fixed. See bug#36121.
> 6. Error messages, like other messages, should not end with a period.
This too has been fixed. See bug#35916.
Best regards,
Stefan Kangas
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- bug#25032: 25.1; `bookmark-set-internal', `bookmark-set-no-overwrite',
Stefan Kangas <=