bug#36159: [PATCH] auto-revert mode doesn't work when changing buffer file name

[Michael Albinus]

Mattias Engdegård <mattiase@acm.org> writes:

Hi Mattias,

> I'm so sorry for having put you through all this, and I wish there
> were anything I could do to make the tests more robust. Does
> autorevert 'feel' reliable and responsive for remote files when you
> use it manually, or is there anything that could cast the
> implementation in doubt?

Don't worry, that's what tests are good for :-)

The basic autorevert part seems to be OK even for remote files. The
trouble comes when file deletion happens;
auto-revert-test02-auto-revert-deleted-file-remote,
auto-revert-test05-global-notify-remote and
auto-revert-test06-write-file-remote become flaky. That is, sometimes
they pass, and sometimes not. I suppose problems in tramp-sh.el, but I
couldn't nail it down yet.

Likely, the combination of file deletion and autorevert hasn't been
tested thoroughly yet for remote files. OTOH, filenotify tests pass all,
also for remote files.

>> For the time being I've marked remote autorevert tests as unstable, so
>> they won't fail in Emacs CI tests. I hope to fix them in the future.
>
> Thank you once again; I suppose that will have to do for now.

Yes. I believe I give myself a timeout for this, some days. After hours
of unsuccessful debugging, I need a restart in mind for that problem.

Best regards, Michael.