[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#36190: 27.0.50; `put-text-property' etc. with buffer argument calls
From: |
Pip Cet |
Subject: |
bug#36190: 27.0.50; `put-text-property' etc. with buffer argument calls current buffer's `after-change-functions' |
Date: |
Sat, 15 Jun 2019 19:27:30 +0000 |
On Sat, Jun 15, 2019 at 3:23 PM Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Pip Cet <pipcet@gmail.com>
> > Date: Sat, 15 Jun 2019 15:14:43 +0000
> > Cc: 36190@debbugs.gnu.org
> >
> > How about simply emulating (with-current-buffer buffer
> > (put-text-property ...)), as the attached patch does? That should fix
> > the immediate problem.
>
> Looks better to me, but I'd suggest a comment explaining why we do
> such an unusual thing.
Sounds good to me. The attached patch contains the comments and a hint
in the documentation. (Maybe the comments should be a FIXME, because
there's really no need to switch buffers at all when there are no
applicable hooks?)
Obviously, feel free to reword as you consider appropriate.
0001-Update-current-buffer-when-changing-text-properties.patch
Description: Text Data
- bug#36190: 27.0.50; `put-text-property' etc. with buffer argument calls current buffer's `after-change-functions', (continued)
- bug#36190: 27.0.50; `put-text-property' etc. with buffer argument calls current buffer's `after-change-functions', Eli Zaretskii, 2019/06/13
- bug#36190: 27.0.50; `put-text-property' etc. with buffer argument calls current buffer's `after-change-functions', Pip Cet, 2019/06/13
- bug#36190: 27.0.50; `put-text-property' etc. with buffer argument calls current buffer's `after-change-functions', Eli Zaretskii, 2019/06/13
- bug#36190: 27.0.50; `put-text-property' etc. with buffer argument calls current buffer's `after-change-functions', Pip Cet, 2019/06/13
- bug#36190: 27.0.50; `put-text-property' etc. with buffer argument calls current buffer's `after-change-functions', Pip Cet, 2019/06/13
- bug#36190: 27.0.50; `put-text-property' etc. with buffer argument calls current buffer's `after-change-functions', Eli Zaretskii, 2019/06/14
- bug#36190: 27.0.50; `put-text-property' etc. with buffer argument calls current buffer's `after-change-functions', Pip Cet, 2019/06/14
- bug#36190: 27.0.50; `put-text-property' etc. with buffer argument calls current buffer's `after-change-functions', Eli Zaretskii, 2019/06/14
- bug#36190: 27.0.50; `put-text-property' etc. with buffer argument calls current buffer's `after-change-functions', Pip Cet, 2019/06/15
- bug#36190: 27.0.50; `put-text-property' etc. with buffer argument calls current buffer's `after-change-functions', Eli Zaretskii, 2019/06/15
- bug#36190: 27.0.50; `put-text-property' etc. with buffer argument calls current buffer's `after-change-functions',
Pip Cet <=
- bug#36190: 27.0.50; `put-text-property' etc. with buffer argument calls current buffer's `after-change-functions', Eli Zaretskii, 2019/06/14
- bug#36190: 27.0.50; `put-text-property' etc. with buffer argument calls current buffer's `after-change-functions', Pip Cet, 2019/06/17
- bug#36190: 27.0.50; `put-text-property' etc. with buffer argument calls current buffer's `after-change-functions', Eli Zaretskii, 2019/06/17
- bug#36190: 27.0.50; `put-text-property' etc. with buffer argument calls current buffer's `after-change-functions', Pip Cet, 2019/06/18