|
From: | Dmitry Gutov |
Subject: | bug#35624: log-view-diff regression |
Date: | Mon, 17 Jun 2019 16:48:55 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 16.06.2019 23:13, Juri Linkov wrote:
Speaking about this approach... What happens when the whole log buffer is shorter than the window it's displayed in?It was difficult for me to test this case because I rely heavily on ediff for development, but ediff has been broken for a week in master. It makes sense to revert changes that break some function completely because currently ediff is unusable giving this error:
That's unfortunate, but I never use it. Maybe file a bug?
But I tried to do ediff's work manually, and can confirm now that when the whole log buffer is shorter than the window then the patch from bug#35860 still works correctly hiding the first line initially.
Great news.I wonder if it would still trip up people who use C-v/M-v sometimes. But a defcustom would solve that, anyway.
[Prev in Thread] | Current Thread | [Next in Thread] |