[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#14769: [PATCH] optimize `concat's literals
|
From: |
Mattias Engdegård |
|
Subject: |
bug#14769: [PATCH] optimize `concat's literals |
|
Date: |
Fri, 21 Jun 2019 11:07:13 +0200 |
20 juni 2019 kl. 02.38 skrev Noam Postavsky <npostavs@gmail.com>:
>
> Looks good to me.
Thanks for looking through the code!
> As a minor aesthetic nitpick, I would suggest using
> `pop', since you're already using `push'.
Not to the same variable though; it isn't a stack. If it's all the same to you,
I'd rather keep that part of the code as it is.