bug#36324: 27.0.50; Error in savehist-save: (wrong-type-argument listp t)

[Lars Ingebrigtsen]

Michael Heerdegen <michael_heerdegen@web.de> writes:

> Though ...
>
>> >   read-string("Confirm password: " nil t nil)
>
> Is it officially allowed to use t as histvar arg?  It doesn't seem to be
> documented.

Yup; this is the way to reproduce the bug simply (with the patch
unreverted):

(savehist-mode)
(read-string "foo" nil t)
(savehist-save t)

I've now reapplied the patch, but restored the t check in the hook and
updated the comment.

The doc string for `read-from-minibuffer' doesn't document the t value
for HISTORY at all -- perhaps that should also be fixed?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no