[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#14769: [PATCH] optimize `concat's literals
|
From: |
Noam Postavsky |
|
Subject: |
bug#14769: [PATCH] optimize `concat's literals |
|
Date: |
Sat, 22 Jun 2019 18:17:25 -0400 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Mattias Engdegård <mattiase@acm.org> writes:
> 20 juni 2019 kl. 02.38 skrev Noam Postavsky <npostavs@gmail.com>:
>
>> As a minor aesthetic nitpick, I would suggest using
>> `pop', since you're already using `push'.
>
> Not to the same variable though; it isn't a stack.
Okay, interesting. I never considered making that stylistic
distinction, I tend to use it on lists freely.
> If it's all the same to you, I'd rather keep that part of the code as it is.
Yeah, no problem.