[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#28434: 25.2; Final "\ No newline at end of file" breaks Emacs patch
From: |
Noam Postavsky |
Subject: |
bug#28434: 25.2; Final "\ No newline at end of file" breaks Emacs patch handling. |
Date: |
Mon, 24 Jun 2019 18:50:58 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Oleksandr Gavenko <gavenkoa@gmail.com> writes:
>
>> It's very annoying as I have no control over file content and sometime can't
>> add final new line.
>
> I think that's kind of unusual -- most text file formats can end in
> newlines.
>
>> Emacs commands in diff mode should tolerate ``\`` message about missing final
>> new line.
>>
>> ediff-diff-ok-lines-regexp is:
>>
>> "^\\([0-9,]+[acd][0-9,]+?$\\|[<>] \\|---\\|.*Warning *:\\|.*No
>> +newline\\|.*missing +newline\\|^?$\\)"
>>
>> and match that line.
>
> I think if you need this, you should add it to that variable, but I
> don't think this would be a good default.
Hmm, the "\ No newline at end of file" thing is a de facto standard, so
shouldn't Emacs recognize it by default?