[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#28434: 25.2; Final "\ No newline at end of file" breaks Emacs patch
|
From: |
Noam Postavsky |
|
Subject: |
bug#28434: 25.2; Final "\ No newline at end of file" breaks Emacs patch handling. |
|
Date: |
Mon, 24 Jun 2019 19:58:32 -0400 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
reopen 28434
tags 28434 - wontfix
severity 28434 minor
quit
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Noam Postavsky <npostavs@gmail.com> writes:
>
>>> I think if you need this, you should add it to that variable, but I
>>> don't think this would be a good default.
>>
>> Hmm, the "\ No newline at end of file" thing is a de facto standard, so
>> shouldn't Emacs recognize it by default?
>
> Hm... is it? I've always thought that was Emacs telling me I was doing
> something wrong. :-)
$ diff --version | head -2
diff (GNU diffutils) 3.5
Copyright (C) 2016 Free Software Foundation, Inc.
$ diff -u <(echo -n foo) <(echo foo)
--- /dev/fd/63 2019-06-24 19:55:40.217569759 -0400
+++ /dev/fd/62 2019-06-24 19:55:40.217569759 -0400
@@ -1 +1 @@
-foo
\ No newline at end of file
+foo
> But if that's the case, then perhaps we should add it?
Yeah I think so.