bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#24046: [PATCH] vc-git: prevent execution of git stash in error cases


From: Lars Ingebrigtsen
Subject: bug#24046: [PATCH] vc-git: prevent execution of git stash in error cases
Date: Tue, 25 Jun 2019 14:03:03 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

npostavs@users.sourceforge.net writes:

> Alexander Kuleshov <kuleshovmail@gmail.com> writes:
>
>> Here is simple patch which adds two additional checks to the 
>> vc-git-stash-show
>> function to check that correct stash name is passed and actually repo
>> has stashes.
>
> I'm not sure this is a good idea, we just end up duplicating checks that
> 'git stash' is going to perform anyway...

I agree, and even if we did want to add these checks, they should be
done in all the stash-related commands...

So I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





reply via email to

[Prev in Thread] Current Thread [Next in Thread]