[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#24960: 25.1; etags incorrectly indexes quoted Erlang atoms
From: |
Lars Ingebrigtsen |
Subject: |
bug#24960: 25.1; etags incorrectly indexes quoted Erlang atoms |
Date: |
Tue, 25 Jun 2019 19:13:55 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Lars Ingebrigtsen <larsi@gnus.org>
>> Cc: David Hull <david.hull@openx.com>, 24960@debbugs.gnu.org
>> Date: Tue, 25 Jun 2019 01:39:10 +0200
>>
>> It looks like the copyright assignment went through, but the patch
>> wasn't applied.
>>
>> I had a look at the patch, but I know nothing about either Erlang or
>> etags.c, so I can't really say whether it's reasonable or not. It looks
>> nice, though. :-)
>
> I think it should go in.
There was one problem in the patch:
if (len > 0)
- make_tag (cp, len, true, s, cp + len - s, lineno, linecharno);
+ /* If the name is quoted, the quotes are not part of the name. */
+ if (len > 2 && cp[0] == '\'' && cp[len - 1] == '\'')
+ {
+ cp++;
+ len -= 2;
+ }
+ make_tag (cp, len, true, s, pos, lineno, linecharno);
I think what was meant was that the make_tag should be in that "if"
branch, so I slapped a brace pair around the new lines.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no