bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#36405: 26.2.90; O_PATH problem on some versions of Cygwin


From: Ken Brown
Subject: bug#36405: 26.2.90; O_PATH problem on some versions of Cygwin
Date: Fri, 28 Jun 2019 17:57:04 +0000
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2

On 6/27/2019 4:47 PM, Paul Eggert wrote:
> --- a/src/fileio.c
> +++ b/src/fileio.c
> @@ -61,6 +61,10 @@ Copyright (C) 1985-1988, 1993-2019 Free Software 
> Foundation, Inc.
>   # include <linux/fs.h>
>   #endif
>   
> +#ifdef __CYGWIN__
> +# undef O_PATH /* Buggy in Cygwin 3.0.0 through 3.0.7.  */
> +#endif

This hunk is not necessary.  The only use of O_PATH in fileio.c is coupled with 
O_DIRECTORY, and this is not affected by the bug.

But, in any case, I agree with Eli's point that your patch is too drastic.  I 
don't see how my patch is intrusive.

Ken

reply via email to

[Prev in Thread] Current Thread [Next in Thread]