[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#12492: Acknowledgement (24.2.50; Open vc-dir buffer easier and faste
From: |
Juri Linkov |
Subject: |
bug#12492: Acknowledgement (24.2.50; Open vc-dir buffer easier and faster) |
Date: |
Fri, 28 Jun 2019 22:17:36 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) |
>> not sure if it should rely on `vc-root-dir' instead
>> (I mean the already existing function `vc-root-dir'
>> that returns the root dir).
>
> I think it should (like my original patch did).
>
> When a project contains several repository roots, you probably want to use
> the closest one. Otherwise, the behavior will be the same.
Yes, the closest one is the right.
>>>> - (define-key map "d" 'vc-dir)
>>>> + (define-key map "d" 'vc-root-dir)
>>>
>>> But this would probably be very controversial. `C-x v /' is a nice
>>> binding, though...
>>
>> I'd prefer an option whose customization would allow `C-x v d'
>> to always use the root.
>
> Honestly, I think these are equivalent proposals, with the exception that
> Lars' keeps the current behavior intact by default.
>
> For those of us who want to change the behavior of 'C-x v d', we can call
> define-key in the init script.
So we could have a new command anyway (with a different name than
the already added function vc-root-dir that returns the root directory),
even if unbound, so users can decide wherever they prefer to bind it.