[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#39662: 28.0.50; Emacs crashes in x_cr_define_fringe_bitmap if (fring
From: |
Eli Zaretskii |
Subject: |
bug#39662: 28.0.50; Emacs crashes in x_cr_define_fringe_bitmap if (fringe-mode 0) |
Date: |
Wed, 19 Feb 2020 17:39:22 +0200 |
> From: Robert Pluim <rpluim@gmail.com>
> Date: Wed, 19 Feb 2020 09:59:21 +0100
> Cc: Dmitry Gutov <dgutov@yandex.ru>, Thibault Polge <thibault@thb.lt>,
> 39662@debbugs.gnu.org
>
> If the user turns fringe-mode back on, diff-hl will use the previously
> created bitmaps, which will be width 1 if
> define-fringe-bitmap decides to use that instead of zero, or will crash if
> x_cr_define_fringe_bitmap does not
> define the bitmap when width == 0
Since passing zero invokes undefined behavior, producing 1 from that
is fine. Crashing is best avoided, though.
> Maybe signaling an error is best :-)
That was my original suggestion/tendency, so I obviously agree.
Thanks.
- bug#39662: 28.0.50; Emacs crashes in x_cr_define_fringe_bitmap if (fringe-mode 0), (continued)
- bug#39662: 28.0.50; Emacs crashes in x_cr_define_fringe_bitmap if (fringe-mode 0), Thibault Polge, 2020/02/18
- bug#39662: 28.0.50; Emacs crashes in x_cr_define_fringe_bitmap if (fringe-mode 0), Robert Pluim, 2020/02/18
- bug#39662: 28.0.50; Emacs crashes in x_cr_define_fringe_bitmap if (fringe-mode 0), Eli Zaretskii, 2020/02/18
- bug#39662: 28.0.50; Emacs crashes in x_cr_define_fringe_bitmap if (fringe-mode 0), Robert Pluim, 2020/02/18
- bug#39662: 28.0.50; Emacs crashes in x_cr_define_fringe_bitmap if (fringe-mode 0), Eli Zaretskii, 2020/02/18
- bug#39662: 28.0.50; Emacs crashes in x_cr_define_fringe_bitmap if (fringe-mode 0), Dmitry Gutov, 2020/02/18
- bug#39662: 28.0.50; Emacs crashes in x_cr_define_fringe_bitmap if (fringe-mode 0), Robert Pluim, 2020/02/18
- bug#39662: 28.0.50; Emacs crashes in x_cr_define_fringe_bitmap if (fringe-mode 0), Dmitry Gutov, 2020/02/18
- bug#39662: 28.0.50; Emacs crashes in x_cr_define_fringe_bitmap if (fringe-mode 0), Eli Zaretskii, 2020/02/18
- bug#39662: 28.0.50; Emacs crashes in x_cr_define_fringe_bitmap if (fringe-mode 0), Robert Pluim, 2020/02/19
- bug#39662: 28.0.50; Emacs crashes in x_cr_define_fringe_bitmap if (fringe-mode 0),
Eli Zaretskii <=
- bug#39662: 28.0.50; Emacs crashes in x_cr_define_fringe_bitmap if (fringe-mode 0), Robert Pluim, 2020/02/26
- bug#39662: 28.0.50; Emacs crashes in x_cr_define_fringe_bitmap if (fringe-mode 0), Dmitry Gutov, 2020/02/26
- bug#39662: 28.0.50; Emacs crashes in x_cr_define_fringe_bitmap if (fringe-mode 0), Robert Pluim, 2020/02/26
- bug#39662: 28.0.50; Emacs crashes in x_cr_define_fringe_bitmap if (fringe-mode 0), Eli Zaretskii, 2020/02/26
- bug#39662: 28.0.50; Emacs crashes in x_cr_define_fringe_bitmap if (fringe-mode 0), Robert Pluim, 2020/02/26
bug#39662: 28.0.50; Emacs crashes in x_cr_define_fringe_bitmap if (fringe-mode 0), Dmitry Gutov, 2020/02/18