[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#56180: 29.0.50; editing file with tramp's "sudo:" changes file owner
From: |
Michael Albinus |
Subject: |
bug#56180: 29.0.50; editing file with tramp's "sudo:" changes file owner |
Date: |
Fri, 24 Jun 2022 17:32:23 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
Version: 29.1
Platon Pronko <platon7pronko@gmail.com> writes:
Hi Platon,
> When I'm editing some root-owned file on the local system with via tramp's
> "sudo:"
> file owner and group are changed to my username (the one Emacs is running
> under).
Thanks for your report!
> It seems that this is a regression from a commit 4e7879f8 in May, which
> tweaked
> how tramp decides whether to chown the file after it is written. I think that
> one of the checks needs to be inverted (patch below), because currently it
> reads
> "if uid is different, then skip setting the uid, but if it is equal then set
> it to the same value".
Indeed. Accidently, the logic of this check was inverted by commits
47fe7a59 and 4e7879f8.
I've pushed your patch to the master branch, closing the bug.
Best regards, Michael.