[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#54034: 29.0.50; Diff prettify broken for empty files
From: |
Matthias Meulien |
Subject: |
bug#54034: 29.0.50; Diff prettify broken for empty files |
Date: |
Wed, 29 Jun 2022 20:22:00 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> [ It'd have been better to file a new bug report for this one, FWIW. ]
>
> I installed the patch below, which seems safe, but is probably
> not optimal. Matthias?
Wouldn't it be safer to simply disable prettification of the "diff
header" when diff-buffer-type isn't equal to git?
In case of the output of the command diff-buffers, I don't see what
would be a usefull prettification of that header.
For other cases, back in 2018 you wrote that "This has only been tested
with Git's diff output." (and I extended diff--font-lock-prettify
without testing other outputs as Git's). Note also that prettification
was already broken with emacs 27.1. See the attached screenshot where
--- #<buffer *Messages*> has one of its minus sign in the fringe when
diff-font-lock-prettify is t. (Your patch fixed that!)
So I guess it won't make any harm to support "diff header"
prettification for Git diff output only:
0001-Disable-prettification-of-diff-header-for-non-Git-di.patch
Description: Text Data
Then it would be possible to introduce a new value for diff-buffer-type,
dedicated to diff-buffers output, and provide a nice prettification
dedicated to that case 🤔 Would a single line like "Differences between buffer
*Help* and *scratch*" be a good idea?
--
Matthias