|
From: | Juri Linkov |
Subject: | bug#59888: [PATCH] Add 'grep-heading-mode' |
Date: | Fri, 09 Dec 2022 09:23:46 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) |
>> How about making this into a defcustom instead of a minor mode? >> >> I'm thinking that something like >> >> (setopt grep-use-headings t) >> >> is a slightly simpler interface to use than >> >> (add-hook 'grep-mode-hook 'grep-heading-mode) >> >> I also think the former plays a bit better with customize. > > This is at the same time less customizable in the sense that something > like > > (add-hook 'grep-mode-hook > (lambda () (when condition) (setq grep-use-headings t))) > > will not work (I think), while conditionally activating a minor mode > certainly works. But I'm open to both approaches. Why not? (setq-local grep-use-headings t) definitely should do the right thing.
[Prev in Thread] | Current Thread | [Next in Thread] |