[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#59545: 29.0.50; Eshell fails to redirect output of sourced eshell fi
From: |
Jim Porter |
Subject: |
bug#59545: 29.0.50; Eshell fails to redirect output of sourced eshell file |
Date: |
Sun, 25 Dec 2022 13:49:43 -0800 |
On 12/24/2022 5:36 PM, Jim Porter wrote:
I'll also see if I can fix the FIXME comment I added, but this is a part
of Eshell that's fairly brittle, and I think the *real* fix for that is
moving to running Eshell commands in a separate thread, as discussed on
emacs-devel.
Ok, it turns out that the regression test that was failing
(eshell-tests/queue-input) wasn't testing the right thing, so I've fixed
that and also found a real bug in the queued-input code. The FIXME
comment is now resolved, although I admit I'm not 100% sure why it
helped improve things. I still don't entirely understand
'eshell-do-eval's inner workings...
I also added an assertion to make sure we're not trying to close I/O
handles more times than we should, which revealed another bug (this time
with my patch), so I've fixed that too.
I think this should resolve all the issues now, so unless anyone has
objections, I'll merge this to the master branch in a few days.
0001-Fix-reference-counting-of-Eshell-I-O-handles.patch
Description: Text document
- bug#59545: 29.0.50; Eshell fails to redirect output of sourced eshell file, Jim Porter, 2022/12/20
- bug#59545: 29.0.50; Eshell fails to redirect output of sourced eshell file, Jim Porter, 2022/12/20
- bug#59545: 29.0.50; Eshell fails to redirect output of sourced eshell file, Michael Albinus, 2022/12/21
- bug#59545: 29.0.50; Eshell fails to redirect output of sourced eshell file, Jim Porter, 2022/12/21
- bug#59545: 29.0.50; Eshell fails to redirect output of sourced eshell file, Eli Zaretskii, 2022/12/21
- bug#59545: 29.0.50; Eshell fails to redirect output of sourced eshell file, Jim Porter, 2022/12/21
- bug#59545: 29.0.50; Eshell fails to redirect output of sourced eshell file, Jim Porter, 2022/12/22
- bug#59545: 29.0.50; Eshell fails to redirect output of sourced eshell file, Jim Porter, 2022/12/24
- bug#59545: 29.0.50; Eshell fails to redirect output of sourced eshell file, Jim Porter, 2022/12/24
- bug#59545: 29.0.50; Eshell fails to redirect output of sourced eshell file,
Jim Porter <=
- bug#59545: 29.0.50; Eshell fails to redirect output of sourced eshell file, Jim Porter, 2022/12/26
- bug#59545: 29.0.50; Eshell fails to redirect output of sourced eshell file, Jim Porter, 2022/12/30
bug#59545: 29.0.50; Eshell fails to redirect output of sourced eshell file, Eli Zaretskii, 2022/12/21