[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#60359: 29.0.60; completion-auto-select set to t skips first argument
From: |
Juri Linkov |
Subject: |
bug#60359: 29.0.60; completion-auto-select set to t skips first argument when completing files |
Date: |
Thu, 29 Dec 2022 20:48:35 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) |
>> Please omit the message only in case when the completions buffer is
>> shown, then the user will see there are more completions. But after
>> typing e.g. `M-x man TAB` that otherwise does nothing the user should see
>> the message. IOW, in case of `completion-auto-help` please use the same
>> condition `(and (eq this-command last-command) completion-auto-help)` as
>> used to pop up the completions.
>
> You mean this, right?
>
> diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
> index 6e42296e7ba..7a720cf2c0a 100644
> --- a/lisp/minibuffer.el
> +++ b/lisp/minibuffer.el
> @@ -1474,7 +1474,10 @@ completion--do-completion
> (if (and (eq this-command last-command)
> completion-auto-help)
> (minibuffer-completion-help beg end))
> (completion--done completion 'exact
> - (unless expect-exact
> + (unless (or expect-exact
> + (and completion-auto-select
> + (eq this-command
> last-command)
> + completion-auto-help))
> "Complete, but not unique"))))
>
> (minibuffer--bitset completed t exact))))))))
Yep, this looks like the right thing to do.