bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#60321: 29.0.60; ruby-mode indentation of hash or array as first arg


From: Aaron Jensen
Subject: bug#60321: 29.0.60; ruby-mode indentation of hash or array as first arg in multiline method call
Date: Sun, 1 Sep 2024 12:28:45 -0700

Hi Dmitry,

Here's a corrected patch for that particular example. Thank you for finding that. I think I missed it because as long as you type the code in, it indents fine. I still have a lot to understand about SMIE, so if anything looks off in my patch, please let me know. 

I didn't change the default. I wasn't sure if you wanted to change the defaults of all of the variables you added in the last round or just this one, so I'll let you handle that the way you want to.

Thanks,


Aaron


On Sun, Sep 01, 2024 at 12:36 PM, Dmitry Gutov <dgutov@yandex.ru> wrote:

Hi Aaron!

On 01/09/2024 03:54, Aaron Jensen wrote:

Updated patch with more precise variables in the new test.

Thanks for taking the initiative.

Here's an example which seems to get worse with the new variable set to nil:

def foo
foo.update(
{
key => value,
other_key: foo
}
)
end

I'd like to flip the default value (now or in Emacs 31), so it would be great to deal with examples like this.


Attachment: 0001-Add-ruby-bracketed-argument-indentation-option.patch
Description: Binary data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]