[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#73359: 30.0.91; editorconfig does not work on xml files
From: |
Eli Zaretskii |
Subject: |
bug#73359: 30.0.91; editorconfig does not work on xml files |
Date: |
Sat, 21 Sep 2024 13:36:25 +0300 |
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Nguyễn Quốc Minh <nqminhuit@gmail.com>,
> 73359@debbugs.gnu.org
> Date: Fri, 20 Sep 2024 14:58:54 -0400
>
> > Stefan, this element of editorconfig-indentation-alist:
> >
> > (nxml-mode nxml-child-indent (nxml-attribute-indent . 2))
> >
> > seems to violate the expected form of the elements, which is
> > (MODE . SETTING). It was added as part of commit 8e143a2f300, whose
> > log says "Sync with upstream", so I suppose this form of the element
> > is supported by upstream, but not by Emacs? I guess we need to
> > replace it with a function or something?
>
> Yup. I pushed the patch below to `emacs-30` for it.
Thanks, I'm therefore closing this bug.
> > Btw, can we clarify the doc string of editorconfig-indentation-alist,
> > where it says "where SETTING should obey the same rules as
> > `editorconfig-indent-size-vars'"? Because if one looks at the doc
> > string of editorconfig-indent-size-vars, the "rules" are either
> > trivial or unclear. If SETTING above should be one or more symbols
> > ("list of variables that need to be set to SIZE") or a function that
> > returns a list of (VAR . VAL) pairs, then why not say that in the doc
> > string of editorconfig-indentation-alist?
>
> I didn't want to do it because it's redundant with the docstring of
> `editorconfig-indent-size-vars`, but see the patch where I tried to
> address your request.
Thanks.