[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#73387: 30.0.90; C-x v v in diff-mode doesn't work after C-c C-n
From: |
Sean Whitton |
Subject: |
bug#73387: 30.0.90; C-x v v in diff-mode doesn't work after C-c C-n |
Date: |
Sun, 22 Sep 2024 13:46:44 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Hello,
On Fri 20 Sep 2024 at 05:08pm +01, Sean Whitton wrote:
> If you do C-c C-n in a diff-mode buffer with multiple hunks, a
> subsequent C-x v v signals a user-error from diff-file-next. I think
> that the bug is in how diff-vc-deduce-fileset invokes diff-file-next.
> I'm not sure exactly how to rework diff-vc-deduce-fileset.
>
> It would be nice to fix this because then C-c C-n C-x v v would be a
> convenient way to commit just a single hunk.
I applied a brute force fix to diff-vc-deduce-fileset.
Attempting to commit a single hunk still fails because after C-c C-n the
file name header is not present, and 'git apply' can't handle a hunk
without a file name header.
We have diff-find-file-name to get the name; I wonder if we should try
to construct a fake file header?
--
Sean Whitton
- bug#73387: 30.0.90; C-x v v in diff-mode doesn't work after C-c C-n, Sean Whitton, 2024/09/20
- bug#73387: 30.0.90; C-x v v in diff-mode doesn't work after C-c C-n,
Sean Whitton <=
- bug#73387: 30.0.90; C-x v v in diff-mode doesn't work after C-c C-n, Dmitry Gutov, 2024/09/23
- bug#73387: 30.0.90; C-x v v in diff-mode doesn't work after C-c C-n, Juri Linkov, 2024/09/24
- bug#73387: 30.0.90; C-x v v in diff-mode doesn't work after C-c C-n, Sean Whitton, 2024/09/24
- bug#73387: 30.0.90; C-x v v in diff-mode doesn't work after C-c C-n, Dmitry Gutov, 2024/09/24
- bug#73387: 30.0.90; C-x v v in diff-mode doesn't work after C-c C-n, Sean Whitton, 2024/09/25
- bug#73387: 30.0.90; C-x v v in diff-mode doesn't work after C-c C-n, Dmitry Gutov, 2024/09/25
- bug#73387: 30.0.90; C-x v v in diff-mode doesn't work after C-c C-n, Sean Whitton, 2024/09/27
- bug#73387: 30.0.90; C-x v v in diff-mode doesn't work after C-c C-n, Dmitry Gutov, 2024/09/27
- bug#73387: 30.0.90; C-x v v in diff-mode doesn't work after C-c C-n, Sean Whitton, 2024/09/29