bug#73552: obsolete (and broken) face attribute :reverse-video

[Mattias Engdegård]

29 sep. 2024 kl. 13.31 skrev Gerd Möllmann <gerd.moellmann@gmail.com>:

>> I first blamed a simple 14 years old mistake in `custom-fix-face-spec`
>> but fixing that doesn't help, not sure why.

Having said that I naturally had to find the bug and it appears to be 
`face-spec-set-2` which only sets attributes that are present in 
`face-x-resources` for some reason.

> I'm pretty sure that I added :italic, :bold, :reverse-video to what
> later became Emacs 21 only for backwards compatibility with the old
> pre-21 face implementation. At least on the surface, because 21 faces
> work completely differently. (I also seem to remeber that reverse-video
> was a synonym for inverse-video in the old code, maybe even
> undocumented.

Thanks. Given Gerd's testimony, the lack of use and general brokenness, I 
propose we just give up on :reverse-video, perhaps removing it from xfaces.c.