bug#74642: Re: bug#74642: 31.0.50; [Patch] Turn off current source line indicator when gdb buffer is killed

[diancheng_wang]

At 2024-12-07 21:25:20, "Eli Zaretskii" <eliz@gnu.org> wrote:

>> From: Diancheng Wang <diancheng_wang@163.com>
>> Cc: 74642@debbugs.gnu.org
>> Date: Thu, 05 Dec 2024 16:37:33 +0800
>> 
>> Eli Zaretskii <eliz@gnu.org> writes:
>> 
>> >> From: Diancheng Wang <diancheng_wang@163.com>
>> >> Cc: 74642@debbugs.gnu.org
>> >> Date: Thu, 05 Dec 2024 15:34:44 +0800
>> >> 
>> >> > Crystal ball says that the regression was caused by the change you
>> >> > submitted (and I installed) in bug#73687.  It added a call to
>> >> > gud-hide-current-line-indicator to gdb-starting and to gud-sentinel.
>> >> > Could you try reverting those changes and see if that solves the
>> >> > problem in Emacs 31?
>> >> 
>> >> Yes, There is a regression in my patch: the arrow on the source line is
>> >> not stopped displaying when "*gud-myprogram" got killed. But Emacs 30
>> >> and Emacs 31 still have another issue:
>> >> gud-highlight-current-line-overlay is not destroyed when
>> >> "*gud-myprogram*" got killed.
>> >
>> > As I already wrote, I don't see the problem in Emacs 30: when I kill
>> > the *gud-myprogram* buffer, the arrow disappears.
>> >
>> >> To reproduce it, you need to evaluate (setq
>> >> gud-highlight-current-line t).
>> >
>> > So in Emacs 30 this only happens when gud-highlight-current-line is
>> > non-nil?
>> 
>> Yes, the highlighted current source line in source file is not
>> un-highlighted when gud-highlight-current-line is non-nil.
>> 
>> >
>> >> I updated my patch to fix this 2 issues, see attachment.
>> >
>> > Does this fix the problem with the current-line indicator (either on
>> > the fringe or as overlay-arrow) in both Emacs 30 and Emacs 31?
>> >
>> > Thanks.
>> 
>> This patch depends on my previous patch, which is commit in master branch:
>> 
>> --8<---------------cut here---------------start------------->8---
>> 
>> commit bd5d84e5d3311e7ab4a7d0091d6c98365927d17a
>> Author: Diancheng Wang <diancheng_wang@163.com>
>> Date:   Tue Oct 8 11:11:24 2024 +0800
>> 
>>     Stop highlighting current line when debuggee is running
>> 
>> --8<---------------cut here---------------end--------------->8---
>> 
>> To apply this fix, Emacs 30 needs this commit.
>
>OK.  But the master branch needs only your last patch, and does not
>need the original patch you posted in this bug report, is that right?

Yes, that's right.