[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#74772: [PATCH] Consistently add wildcards for completion-pcm-leading
From: |
Spencer Baugh |
Subject: |
bug#74772: [PATCH] Consistently add wildcards for completion-pcm-leading-wildcard |
Date: |
Tue, 10 Dec 2024 12:48:23 -0500 |
Tags: patch
completion-pcm--find-all-completions has two different phases:
First we turn the minibuffer text into a regex and matches
completion alternatives against it. If that finds no matches,
then we strip some text off the completions and minibuffer text
and call ourselves recursively to find completions, then filter
the results with the removed text (converted into a regex).
Because of this, completion-pcm-leading-wildcard had
inconsistent behavior: in the second phase, the filter created
from the removed text would have a leading wildcard. That
effectively adds wildcards in the middle of the minibuffer text
at the start of each "word". But the first phrase created a
regex which had no such wildcards. Thus, the two phases could
get substantially different results.
We fix this by changing completion-pcm-leading-wildcard to
consistently add a leading wildcard for each word. This was
always my intention.
* lisp/minibuffer.el (completion-pcm--string->pattern): Include
a wildcard after each delimter with
completion-pcm-leading-wildcard.
* lisp/minibuffer.el (completion-pcm-leading-wildcard): Update
docs.
* doc/emacs/mini.texi (Completion Styles): Update docs.
In GNU Emacs 29.2.50 (build 11, x86_64-pc-linux-gnu, X toolkit, cairo
version 1.15.12, Xaw scroll bars) of 2024-12-02 built on
igm-qws-u22796a
Repository revision: ddde0f4eead134864c7db775c0aeb93f201c35f6
Repository branch: my-emacs-29
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Rocky Linux 8.10 (Green Obsidian)
Configured using:
'configure --with-x-toolkit=lucid --without-gpm --without-gconf
--without-selinux --without-imagemagick --with-modules --with-gif=no
--with-tree-sitter --with-native-compilation=aot
PKG_CONFIG_PATH=/usr/local/home/garnish/libtree-sitter/0.22.6-1/lib/pkgconfig/'
0001-Consistently-add-wildcards-for-completion-pcm-leadin.patch
Description: Text Data
- bug#74772: [PATCH] Consistently add wildcards for completion-pcm-leading-wildcard,
Spencer Baugh <=
- bug#74772: [PATCH] Consistently add wildcards for completion-pcm-leading-wildcard, Eli Zaretskii, 2024/12/10
- bug#74772: [PATCH] Consistently add wildcards for completion-pcm-leading-wildcard, Spencer Baugh, 2024/12/10
- bug#74772: [PATCH] Consistently add wildcards for completion-pcm-leading-wildcard, Eli Zaretskii, 2024/12/10
- bug#74772: [PATCH] Consistently add wildcards for completion-pcm-leading-wildcard, Spencer Baugh, 2024/12/10
- bug#74772: [PATCH] Consistently add wildcards for completion-pcm-leading-wildcard, Eli Zaretskii, 2024/12/21
- bug#74772: [PATCH] Consistently add wildcards for completion-pcm-leading-wildcard, Stefan Monnier, 2024/12/21
- bug#74772: [PATCH] Consistently add wildcards for completion-pcm-leading-wildcard, Eli Zaretskii, 2024/12/26