bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#74781: [PATCH] Add `browse-url-qutebrowser'


From: Daniel Mendler
Subject: bug#74781: [PATCH] Add `browse-url-qutebrowser'
Date: Wed, 11 Dec 2024 11:45:38 +0100
User-agent: Gnus/5.13 (Gnus v5.13)

Robert Pluim <rpluim@gmail.com> writes:

>>>>>> On Wed, 11 Dec 2024 10:07:08 +0100, Daniel Mendler 
>>>>>> <mail@daniel-mendler.de> said:
> The emacs help system applies heuristics which are not always
> accurate, and donʼt always return an answer, hence the version tags.

Thanks, I added the version tags. See the updated patch.

>     >> We have `xdg-runtime-dir' in xdg.el
>
>     Daniel> The goal was to avoid loading `xdg.el' unnecessarily for this 
> trivial
>     Daniel> function, which is just a wrapper around `getenv'. Do you suggest 
> to use
>     Daniel> `declare-function' and require xdg inside 
> `browse-url-qutebrowser-send'?
>
> That would work.

I would be pragmatic and keep the (getenv "XDG_RUNTIME_DIR"), instead of
replacing it by this:

(declare-function xdg-runtime-dir "xdg")
(require 'xdg)
(xdg-runtime-dir)

Daniel

Attachment: 0001-Add-browse-url-qutebrowser.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]