bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#74854: [PATCH] Improve menu separator display on ttys slightly


From: Eli Zaretskii
Subject: bug#74854: [PATCH] Improve menu separator display on ttys slightly
Date: Fri, 13 Dec 2024 18:16:51 +0200

> From: Gerd Möllmann <gerd.moellmann@gmail.com>
> Date: Fri, 13 Dec 2024 16:09:30 +0100
> 
> Improvements:
> 
> 1. Separators are displayed as lines over the whole menu, not
>     only as "--".
> 
> 2. Support for 3 types of separators: --space -> line
>     of spaces, --double-line -> line of '=', others -> line of '-'

Thanks.

> +static void
> +display_tty_menu_separator (struct it *it, const char *label, int width)
> +{
> +  static char sep[200];

Why 200?  GNU Coding Standards frown on arbitrary limits.

How about using alloca with 'width' as its argument?





reply via email to

[Prev in Thread] Current Thread [Next in Thread]