bug#74920: 31.0.50; 'should' defeats warning from set-advertised-calling-convention

[Stefan Kangas]

Severity: minor

Create a file foo.el with this content:

    ;; -*- lexical-binding: t; -*-
    (defun foo (&optional a) a)
    (set-advertised-calling-convention 'foo '(a) '"31.1")
    (foo)

Create a second file bar.el with this:

    ;; -*- lexical-binding: t; -*-
    (load "foo")
    (require 'ert)
    (foo)
    (should (foo))

Byte-compile bar.el and observe that there is only one warning:

bar.el:4:2: Warning: ‘foo’ called with 0 arguments, but requires 1

Expected is two warnings, like this:

bar.el:4:2: Warning: ‘foo’ called with 0 arguments, but requires 1
bar.el:5:2: Warning: ‘foo’ called with 0 arguments, but requires 1