bug#74786: [PATCH] Add custom args to test compile step

[O'Brien, Will]

On Sun, Dec 15 2024 at 02:17, Randy Taylor <dev@rjt.dev> wrote:

> On Wednesday, December 11th, 2024 at 11:31, O'Brien, Will 
> <will.08rien@gmail.com> wrote:
>> [...]
>> 
>> Ah, thanks! I've attached a new patch with the simplification.
>> 
>> best
>> --
>> will
>
> Thanks for working on this.
>
> +(defcustom go-ts-mode-test-args nil
> +  "List of extra args for the Go test commands."
> Should we call this `go-ts-mode-test-flags' instead?
> That seems to be the parlance golang uses, and there is an official
> `-args' that go test supports that has a specific behaviour:
>       -args
>           Pass the remainder of the command line (everything after -args)
>           to the test binary, uninterpreted and unchanged.
>           Because this flag consumes the remainder of the command line,
>           the package list (if present) must appear before this flag.
>
> +  (compile (format "go test %s -v %s -run '%s'"
> +                   (string-join go-ts-mode-test-args)
> With the above in mind, we may want to move the %s to the absolute
> end so that -args could be used without catastrophe.

Got it.  Right I'll work on this and test out a few options with
combinations flags.

> This will also need a commit message and a NEWS entry.
> See the CONTRIBUTE file for details.

Ok, will send new patch with code changes and NEW entry along with
a commit message.

Thank you!

--
will