[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#74983: [PATCH] Use `keymap-set' instead of `define-key' in emacs lis
From: |
Hong Xu |
Subject: |
bug#74983: [PATCH] Use `keymap-set' instead of `define-key' in emacs lisp intro |
Date: |
Fri, 20 Dec 2024 13:50:15 -0800 |
User-agent: |
mu4e 1.12.8; emacs 29.4 |
On 2024-12-19 Thu 23:01 GMT-08, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Hong Xu <hong@topbug.net>
>> Date: Thu, 19 Dec 2024 14:36:29 -0800
>>
>> * Since `define-key' is considered legacy and we encourage `keymap-set'
>> now.
>
> Thanks. But the second chunk is not really right, since we have many
> more define-key there than keymap-set.
>
> So my suggestion is not to _replace_ define-key with keymap-set, but
> instead describe _both_, explaining that as of Emacs 29 we are
> migrating towards keymap-set, which is preferred.
Thanks, I agree. I've made a followup patch. For some reason the
followup patch didn't attach to the Message ID of this thread and a new
bug 74999 was created.
--
Hong