bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#74963: Ambiguous treesit named and anonymous nodes in ruby-ts-mode


From: Dmitry Gutov
Subject: bug#74963: Ambiguous treesit named and anonymous nodes in ruby-ts-mode
Date: Thu, 26 Dec 2024 03:00:38 +0200
User-agent: Mozilla Thunderbird

On 25/12/2024 09:52, Juri Linkov wrote:

Given that we're already calling a predicate every time (in
ruby-ts-mode), we might as well add one more check. See the patch at the
end.

Thanks, I tried the patch.  It was broken, so needed to edit manually.

Maybe something regarding whitespace at the end?

Also the new key 'w' doesn't work in diff buffers, need to fix it as well.

The binding for 'diff-kill-ring-save'? Seems to work here, as long as the diff buffer is in read-only mode.

Adding the check for "named" fixes the first two cases, but then C-M-f
inside "def" jumps to after "baaz". Could be worked around with a
special case, but I wonder what this difference comes from (haven't
properly debugged yet).

I see no problems with your patch.  Everything works nicely.

Hmm, I can't reproduce it either anymore.

Thanks for testing, pushed to master now (unfortunately the commit message refers to bug#73404).





reply via email to

[Prev in Thread] Current Thread [Next in Thread]