Hi Mike,
Mike Fulton wrote:
> I have created the patch files (and tested them on z/OS) for the
> iconv changes and the unit tests that you requested.
> Please see:
> https://github.com/ZOSOpenTools/libiconvport/tree/zostagging/git-patches/zostagging
> directory. I am happy to put it into whatever format you like.
The URL now is https://github.com/ZOSOpenTools/libiconvport/tree/main/git-patches/zostagging .
Thanks. The patches look roughly OK; details below.
The next step is to get the copyright assignment to the FSF in place. That's
a precondition for moving the changes upstream. I'll write to you about this
in private mail.
Details:
- iconv.c.patch: I would refactor the z/OS specific code to a separate file
zos.h or zos-util.h. Adding the 'tocode' parameter to the 'convert'
function for all platforms is OK.
- Makefile.in.patch: The "SHELL ?= ..." patch cannot be added: This Makefile
needs to stay in POSIX make syntax; GNU make additions are not OK.
The other part, line 18-19, should use a tab for indentation, as usual in
Makefiles.
- check-tag.patch: Looks OK. Just a suggestion: Instead of testing the value
of 'uname -s', better test the value of @host_os@ that can be passed from
the Makefile. In GNU, this is the uniform way of getting the canonicalized
string that designates the operating system. With it, the previous methods
(arch, uname, etc.) are no longer relevant.
where I believe I have incorporated your comments.
I have also sent a note to
assign@gnu.org to get copyright assignment to the FSF. I can forward it
on if you have not seen it yet.
Bruno