PSPP-BUG: [bug #23263] Shouldn't need GSL for isinf, isnan, and finite

[Ben Pfaff]

Update of bug #23263 (project pspp):

                  Status:                    None => Ready for Test/Review  

    _______________________________________________________

Follow-up Comment #4:

Here is a patch that integrates the new gnulib modules into PSPP, changing it
back to use the standard C99 functions.

Summary:

    Use standard C99 isfinite, isnan, isinf in place of GSL substitutes.
    
    In change a9afcdd22, "Use gsl_isnan instead of isnan, ...," isfinite,
    isnan, and isinf were changed to use the GSL substitutes because of
    lack of portability of the C99 versions.  Now, gnulib has portable
    versions of all of these, so change them back.
    
    This commit changes calls to gsl_finite() to call isfinite() instead
    of the equivalent finite().  isfinite() is correct here: both
gsl_finite()
    and finite() return true for NaNs, which is a surprising result given
    that a NaN is definitely not finite, but isfinite() returns false and,
    more importantly, behaves as actually wanted in each place it is used
    in PSPP code.
    
    This commit requires upgrading gnulib to at least change 5183a0e3c,
    "Add missing dependencies on new m4/exponent[fdl].m4 files," or later,
    and re-running "make -f Smake".


(file #16190)
    _______________________________________________________

Additional Item Attachment:

File name: foo.patch                      Size:8 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?23263>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/