[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
PSPP-BUG: [bug #24021] Wishlist: RELIABILITY Command
|
From: |
Ben Pfaff |
|
Subject: |
PSPP-BUG: [bug #24021] Wishlist: RELIABILITY Command |
|
Date: |
Sun, 14 Sep 2008 18:44:29 +0000 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.1) Gecko/20061205 Iceweasel/2.0.0.1 (Debian-2.0.0.1+dfsg-1) |
Follow-up Comment #3, bug #24021 (project pspp):
I did a quick skim over the source code for this and on that basis it looks
good to me.
One thing I noticed: please use the pow2() inline function already in misc.h
instead of adding a new macro to do the same thing. Using a macro just makes
optimization harder for the compiler, at least where the argument is more
complicated than a single variable name.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?24021>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/