|
From: | Ben Pfaff |
Subject: | PSPP-BUG: [bug #11975] AGGREGATE should support MEDIAN function |
Date: | Fri, 19 Sep 2008 03:54:25 +0000 |
User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.1) Gecko/20061205 Iceweasel/2.0.0.1 (Debian-2.0.0.1+dfsg-1) |
Follow-up Comment #8, bug #11975 (project pspp): The patch looks good. A few comments: * I think that the function dict_get_case_weight() could usefully simplify a small bit of logic. * My thought was actually slightly different from what you implemented: I had the notion that the contents of the while loop that your patch inserts into initialize_aggregate_info() would actually be put into accumulate_aggregate_info(). Then there is no additional data pass in initialize_aggregate_info(), because we use the one that is already happening. _______________________________________________________ Reply to this item at: <http://savannah.gnu.org/bugs/?11975> _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |