PSPP-BUG: [bug #25795] Problem saving changes

[John Darrington]

Follow-up Comment #5, bug #25795 (project pspp):

Unfortunately this isn't a correct solution to the problem.  It'll break a
number of other things, because we need the destination to remain intact if
renaming the file fails for any reason.

Currently we have:

 rename (rf->tmp_name, rf->file_name);

one solution would be to change this to:

 rename (rf->file_name, tmp2_name);
 if ( ! rename (rf->tmp_name, rf->file_name))
  rename (tmp2_name, rf->file_name);

but that brings some issues of its own.

Alternatively if there is a safe equivalent to "rename" in Mingw which can
safely and atomically move files from one filesystem entry to another, then we
could use that.

So we still have to come up with a solution to this problem, but at least we
understand it better.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?25795>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/