PSPP-BUG: [bug #30689] GUI crashes after a syntax error.

[Ben Pfaff]

Update of bug #30689 (project pspp):

                  Status:                    None => Ready for Test/Review  

    _______________________________________________________

Follow-up Comment #6:

The following patch fixes the crash and the glib criticals, but it also
eliminates pending transformations from the GUI.  That might not be a bad
thing, since they do tend to confuse new users at least.

John, what do you think?


>From a3d409c10697a73dc2482f8f3632ff6994b2c2ea Mon Sep 17 00:00:00 2001
From: Ben Pfaff <address@hidden>
Date: Sat, 30 Oct 2010 10:31:06 -0700
Subject: [PATCH] executor: Execute pending transformations after processing
syntax.

Bug #30689.
---
 src/ui/gui/executor.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/src/ui/gui/executor.c b/src/ui/gui/executor.c
index 6ccb5a5..7b4d10c 100644
--- a/src/ui/gui/executor.c
+++ b/src/ui/gui/executor.c
@@ -1,5 +1,5 @@
 /* PSPPIRE - a graphical user interface for PSPP.
-   Copyright (C) 2007, 2009  Free Software Foundation
+   Copyright (C) 2007, 2009, 2010  Free Software Foundation
 
    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
@@ -95,6 +95,8 @@ execute_syntax (struct getl_interface *sss)
 
   lex_destroy (lexer);
 
+  proc_execute (the_dataset);
+
   psppire_dict_replace_dictionary (the_data_store->dict,
                                   dataset_dict (the_dataset));
 
-- 
1.7.1



    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?30689>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/