Re: PSPP-BUG: Problem with building from current tarball

[John Darrington]

On Fri, Jan 03, 2020 at 05:13:55PM -0800, Ben Pfaff wrote:
     What triggers this failure?


I don't know what triggers it, but I think I can see the problem.
In psppire-output-view.c (renderer) there is the following code:

  GdkWindow *win = gtk_layout_get_bin_window (view->output);
  GdkDrawingContext *ctx =  gdk_window_begin_draw_frame (win, region);
  cairo_t *cr = gdk_drawing_context_get_cairo_context (ctx);

  if (view->xr == NULL)
    create_xr (view);


and if one looks at the implementation of create_xr one of the first
things it does is to call

   GdkWindow *win = gtk_layout_get_bin_window (view->output);
   GdkDrawingContext *ctx = gdk_window_begin_draw_frame (win, region);


So, if view->xr is NULL, then  gdk_window_begin_draw_frame will be called
twice on the same WIN, without a call to gdk_window_end_draw_frame between
the calls.

A similar problem exists further down the file around line 350


J'







     On Fri, Jan 3, 2020, 11:45 AM Harry Thijssen <address@hidden> wrote:
     
     > Hi
     >
     > It builds now. However the program still crashes. With GDB I get this:
     >
     > (psppire.exe:6808): GLib-GIO-CRITICAL **: 20:22:19.880:
     > g_content_type_is_a: assertion 'type != NULL' failed
     > (psppire.exe:6808): GLib-GIO-CRITICAL **: 20:22:19.889:
     > g_content_type_is_a: assertion 'type != NULL' failed
     > (psppire.exe:6808): Pango-WARNING **: 20:22:22.432: couldn't load font
     > "Sans Serif Not-Rotated 9", falling back to "Sans Not-Rotated 9", expect
     > ugly output.
     > (psppire.exe:6808): Pango-WARNING **: 20:22:22.442: couldn't load font
     > "Sans Serif Bold Not-Rotated 9", falling back to "Sans Bold Not-Rotated 
9",
     > expect ugly output.
     > [Thread 6808.0x1ab0 exited with code 0]
     > [New Thread 6808.0x978]
     > [New Thread 6808.0xb10]
     > [Thread 6808.0x1f38 exited with code 0]
     > [Thread 6808.0x4f4 exited with code 0]
     > [Thread 6808.0x1c34 exited with code 0]
     >
     > (psppire.exe:6808): Gdk-CRITICAL **: 20:27:16.320: The window
     > 0000000006A25230 already has a drawing context. You cannot call
     > gdk_window_begin_draw_frame() without calling gdk_window_end_draw_frame()
     > first.
     > (psppire.exe:6808): Gdk-CRITICAL **: 20:27:16.417:
     > gdk_drawing_context_get_cairo_context: assertion 'GDK_IS_DRAWING_CONTEXT
     > (context)' failed
     >
     > Thread 1 received signal SIGSEGV, Segmentation fault.
     > 0x0000000068dcf325 in ?? () from C:\Program Files\PSPP\bin\libcairo-2.dll
     > (gdb) backtrace
     > #0  0x0000000068dcf325 in ?? () from C:\Program
     > Files\PSPP\bin\libcairo-2.dll
     > #1  0x00000000004fc614 in xr_set_cairo (xr=0x6abd340, cairo=0x0) at
     > src/output/cairo.c:766
     > #2  0x00000000004ff9a4 in xr_driver_create (cairo=0x0, options=0x116eb40)
     > at src/output/cairo.c:1860
     > #3  0x00000000004420d7 in create_xr (view=0x67a7820) at
     > src/ui/gui/psppire-output-view.c:173
     > #4  0x00000000004423b0 in rerender (view=0x67a7820) at
     > src/ui/gui/psppire-output-view.c:233
     > #5  0x0000000000443030 in on_style_updated (toplevel=0x680dd70,
     > view=0x67a7820)
     >     at src/ui/gui/psppire-output-view.c:497
     > #6  0x0000000063a461c3 in ?? () from C:\Program
     > Files\PSPP\bin\libgobject-2.0-0.dll
     > #7  0x0000000063a57d05 in ?? () from C:\Program
     > Files\PSPP\bin\libgobject-2.0-0.dll
     > #8  0x0000000063a5ffc1 in ?? () from C:\Program
     > Files\PSPP\bin\libgobject-2.0-0.dll
     > #9  0x0000000063a60518 in ?? () from C:\Program
     > Files\PSPP\bin\libgobject-2.0-0.dll
     > #10 0x0000000063a461c3 in ?? () from C:\Program
     > Files\PSPP\bin\libgobject-2.0-0.dll
     > #11 0x0000000063a57ec0 in ?? () from C:\Program
     > Files\PSPP\bin\libgobject-2.0-0.dll
     > #12 0x0000000063a5ffc1 in ?? () from C:\Program
     > Files\PSPP\bin\libgobject-2.0-0.dll
     > #13 0x0000000063a60518 in ?? () from C:\Program
     > Files\PSPP\bin\libgobject-2.0-0.dll
     > #14 0x0000000066653364 in ?? () from C:\Program
     > Files\PSPP\bin\libgtk-3-0.dll
     > #15 0x0000000066511a39 in ?? () from C:\Program
     > Files\PSPP\bin\libgtk-3-0.dll
     > #16 0x00000000664f7980 in ?? () from C:\Program
     > Files\PSPP\bin\libgtk-3-0.dll
     > #17 0x00000000664f79ab in ?? () from C:\Program
     > Files\PSPP\bin\libgtk-3-0.dll
     > #18 0x00000000664f79ab in ?? () from C:\Program
     > Files\PSPP\bin\libgtk-3-0.dll
     > #19 0x00000000664f79ab in ?? () from C:\Program
     > Files\PSPP\bin\libgtk-3-0.dll
     > #20 0x00000000664f79ab in ?? () from C:\Program
     > Files\PSPP\bin\libgtk-3-0.dll
     > #21 0x00000000664de636 in ?? () from C:\Program
     > Files\PSPP\bin\libgtk-3-0.dll
     > #22 0x0000000063a461c3 in ?? () from C:\Program
     > Files\PSPP\bin\libgobject-2.0-0.dll
     > #23 0x0000000063a57d05 in ?? () from C:\Program
     > Files\PSPP\bin\libgobject-2.0-0.dll
     > #24 0x0000000063a5ffc1 in ?? () from C:\Program
     > Files\PSPP\bin\libgobject-2.0-0.dll
     > #25 0x0000000063a60518 in ?? () from C:\Program
     > Files\PSPP\bin\libgobject-2.0-0.dll
     > #26 0x0000000070ed713f in ?? () from C:\Program
     > Files\PSPP\bin\libgdk-3-0.dll
     > #27 0x0000000070ec16d0 in ?? () from C:\Program
     > Files\PSPP\bin\libgdk-3-0.dll
     > #28 0x00000000685f43e3 in ?? () from C:\Program
     > Files\PSPP\bin\libglib-2.0-0.dll
     > #29 0x00000000685f389e in ?? () from C:\Program
     > Files\PSPP\bin\libglib-2.0-0.dll
     > #30 0x00000000685f3bf8 in ?? () from C:\Program
     > Files\PSPP\bin\libglib-2.0-0.dll
     > #31 0x00000000685f3e0d in ?? () from C:\Program
     > Files\PSPP\bin\libglib-2.0-0.dll
     > #32 0x000000006d5eb20d in ?? () from C:\Program
     > Files\PSPP\bin\libgio-2.0-0.dll
     > #33 0x0000000000412105 in main (argc=1, argv=0x3016850) at
     > src/ui/gui/main.c:323
     > (gdb)
     >
     > Op wo 1 jan. 2020 om 18:22 schreef Ben Pfaff <address@hidden>:
     >
     >> Thanks for the report.  The problem should be fixed on master now, and
     >> a new source tarball should get uploaded soon.
     >>
     >> On Wed, Jan 1, 2020 at 8:42 AM Harry Thijssen <address@hidden>
     >> wrote:
     >> >
     >> > Hi
     >> >
     >> > When building the MSWindows package from the current master tarball I
     >> get an error. See below:
     >> >
     >> > libtool: link: /usr/bin/i686-w64-mingw32-ranlib 
src/.libs/libpspp-core.a
     >> > libtool: link: rm -fr src/.libs/libpspp-core.lax
     >> > libtool: link: ( cd "src/.libs" && rm -f "libpspp-core.la" && ln -s
     >> "../libpspp-core.la" "libpspp-core.la" )
     >> > /bin/sh ./libtool  --tag=CC   --mode=link i686-w64-mingw32-gcc -Wall 
-W
     >> -Wwrite-strings -Wstrict-prototypes -Wpointer-arith -Wno-sign-compare
     >> -Wmissing-prototypes -ggdb   `: 
/usr/i686-w64-mingw32/sys-root/mingw/bin`
     >> -Wl,--exclude-libs=libintl.a -Wl,--exclude-libs=libiconv.a
     >> -Wl,--no-keep-memory -o src/ui/terminal/pspp.exe  src/ui/terminal/
     >> libui.la src/ui/libuicommon.la src/libpspp.la src/libpspp-core.la
     >> -L/usr/i686-w64-mingw32/sys-root/mingw/lib -lpangocairo-1.0 -lpango-1.0
     >> -lgobject-2.0 -lglib-2.0 -lintl -lcairo
     >> -L/usr/i686-w64-mingw32/sys-root/mingw/lib -lreadline
     >> -R/usr/i686-w64-mingw32/sys-root/mingw/lib
     >> -L/usr/i686-w64-mingw32/sys-root/mingw/lib -lgsl -lgslcblas -lm
     >> /usr/i686-w64-mingw32/sys-root/mingw/lib/libiconv.dll.a
     >> -L/usr/i686-w64-mingw32/sys-root/mingw/lib -lreadline -lgslcblas -lz
     >> /usr/i686-w64-mingw32/sys-root/mingw/lib/libintl.dll.a
     >> -L/usr/i686-w64-mingw32/sys-root/mingw/lib
     >> > libtool: link: i686-w64-mingw32-gcc -Wall -W -Wwrite-strings
     >> -Wstrict-prototypes -Wpointer-arith -Wno-sign-compare 
-Wmissing-prototypes
     >> -ggdb -Wl,--exclude-libs=libintl.a -Wl,--exclude-libs=libiconv.a
     >> -Wl,--no-keep-memory -o src/ui/terminal/.libs/pspp.exe
     >> src/ui/terminal/.libs/libui.a -L/usr/i686-w64-mingw32/sys-root/mingw/lib
     >> src/ui/.libs/libuicommon.a src/.libs/libpspp.a src/.libs/libpspp-core.a
     >> -lxml2 -lpq -lws2_32 -lpangocairo-1.0 -lpango-1.0 -lgobject-2.0 
-lglib-2.0
     >> -lintl -lcairo -lgsl
     >> /usr/i686-w64-mingw32/sys-root/mingw/lib/libiconv.dll.a -lreadline
     >> -lgslcblas -lz /usr/i686-w64-mingw32/sys-root/mingw/lib/libintl.dll.a
     >> -L/usr/i686-w64-mingw32/sys-root/mingw/lib
     >> >
     >> 
/usr/lib64/gcc/i686-w64-mingw32/8.2.0/../../../../i686-w64-mingw32/bin/ld:
     >> src/.libs/libpspp.a(liboutput_la-pivot-table.o): in function
     >> `pivot_table_dump':
     >> >
     >> 
/home/harry/pspp-master-20200101/pspp-1.3.0-g580521/src/output/pivot-table.c:1491:
     >> undefined reference to `ctime_r'
     >> > collect2: error: ld returned 1 exit status
     >> > make[2]: *** [Makefile:7886: src/ui/terminal/pspp.exe] Error 1
     >> > make[2]: Leaving directory
     >> '/home/harry/pspp-master-20200101/pspp-1.3.0-g580521'
     >> > make[1]: *** [Makefile:12829: all-recursive] Error 1
     >> > make[1]: Leaving directory
     >> '/home/harry/pspp-master-20200101/pspp-1.3.0-g580521'
     >> > make: *** [Makefile:6401: all] Error 2
     >> >
     >> >
     >> > Have fun
     >> > _______________________________________________
     >> > Bug-gnu-pspp mailing list
     >> > address@hidden
     >> > https://lists.gnu.org/mailman/listinfo/bug-gnu-pspp
     >>
     >

     _______________________________________________
     Bug-gnu-pspp mailing list
     address@hidden
     https://lists.gnu.org/mailman/listinfo/bug-gnu-pspp