bug-gnu-pspp
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: PSPP-BUG: [bug #58600] Floating point execption in create_matrix_rea


From: John Darrington
Subject: Re: PSPP-BUG: [bug #58600] Floating point execption in create_matrix_reader_from_case_reader
Date: Sun, 21 Jun 2020 13:37:32 +0200
User-agent: Mutt/1.10.1 (2018-07-13)

On Sat, Jun 20, 2020 at 10:55:33PM -0700, Ben Pfaff wrote:
     On Sat, Jun 20, 2020 at 10:35 PM John Darrington <
     >
     > return xcalloc (sizeof (unsigned long int), DIV_RND_UP (n,
     > BITS_PER_ULONG));
     > ./src/libpspp/bit-vector.c:28
     >
     > struct fmt_guesser **fg = xcalloc (sizeof *fg, n_vars);
     > ./src/ui/gui/psppire-import-assistant.c:1244
     >
     > struct value_node **nodes = xcalloc (sizeof *nodes, n_vals);
     > ./src/math/categoricals.c:483
     
     
     Yes. I did the same grep just before I wrote that but I must have
     overlooked them somehow.
     
I pushed a fix for these.  

I wonder if we ought to use the XCALLOC macro from gnulib which would
stop this kind of error from occuring?

J'



reply via email to

[Prev in Thread] Current Thread [Next in Thread]