PSPP-BUG: [bug #63606] Underlinking of liboutput

[Michael Orlitzky]

URL:
  <https://savannah.gnu.org/bugs/?63606>

                 Summary: Underlinking of liboutput
                 Project: PSPP
               Submitter: mjo
               Submitted: Sun 01 Jan 2023 02:24:20 PM UTC
                Category: Compilation/Portability
                Severity: 5 - Average
                  Status: None
             Assigned to: None
             Open/Closed: Open
                 Release: None
         Discussion Lock: Any
                  Effort: 0.00


    _______________________________________________________

Follow-up Comments:


-------------------------------------------------------
Date: Sun 01 Jan 2023 02:24:20 PM UTC By: Michael Orlitzky <mjo>
We have an old bug in Gentoo,

  https://bugs.gentoo.org/732048

for an older version of pspp. While trying to reproduce this with either the
lld or mold linkers and "-Wl,--as-needed" in my LDFLAGS, I get the following
build failure:


(cd "./examples" \
         &&
"/var/lib/portage/tmp/portage/sci-mathematics/pspp-1.6.2-r1/work/pspp-1.6.2/src/ui/terminal/pspp"
../doc/pspp-figures/chisquare.sps -o - -O format=spv) >
doc/pspp-figures/chisquare.spv.tmp
/var/lib/portage/tmp/portage/sci-mathematics/pspp-1.6.2-r1/work/pspp-1.6.2/src/ui/terminal/.libs/pspp:
symbol lookup error:
/var/lib/portage/tmp/portage/sci-mathematics/pspp-1.6.2-r1/work/pspp-1.6.2/src/.libs/libpspp-1.6.2.so:
undefined symbol: pango_font_description_free


So, the build of pspp succeeded, but it has some unresolved symbols, stemming
from libpspp. I've tracked this down, and I believe it's due to $(CAIRO_LIBS)
being missing from src_output_liboutput_la_LIBADD. I wasn't able to get the
git build working, but hacking $(CAIRO_LIBS) into that variable in the
top-level Makefile fixed the issue for me.

Looking through the source, it looks like liboutput should also be linked with
libxml2, but there are presently no observable problems caused by it. However,
the Gentoo bug report that started my investigation looks like it might have
been caused by that, so if liboutput is indeed using libxml2 stuff, I think
the libxml2 libs should also be appended to src_output_liboutput_la_LIBADD to
prevent similar issues in the future.







    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?63606>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/