[Bug-gnulib] Re: new module: time_r; plus fixes for timegm, mktime, strftime

[Paul Eggert]

Simon Josefsson <address@hidden> writes:

> time_r.c: In function `rpl_gmtime_r':
> time_r.c:62: too few arguments to function `copy_tm_result'

Thanks for that bug report, along with your other report about
'restrict'.  I installed the following patch.

Index: ChangeLog
===================================================================
RCS file: /cvsroot/gnulib/gnulib/ChangeLog,v
retrieving revision 1.88
diff -p -u -r1.88 ChangeLog
--- ChangeLog   6 Sep 2003 21:34:07 -0000       1.88
+++ ChangeLog   8 Sep 2003 00:40:14 -0000
@@ -1,3 +1,8 @@
+2003-09-07  Paul Eggert  <address@hidden>
+
+       * modules/time_r: Depend on 'restrict'.  Fix from Simon Josefsson in
+       <http://mail.gnu.org/archive/html/bug-gnulib/2003-09/msg00028.html>.
+
 2003-09-06  Paul Eggert  <address@hidden>
 
        * MODULES.html.sh (func_all_modules): Add time_r.
Index: lib/ChangeLog
===================================================================
RCS file: /cvsroot/gnulib/gnulib/lib/ChangeLog,v
retrieving revision 1.548
diff -p -u -r1.548 ChangeLog
--- lib/ChangeLog       6 Sep 2003 21:34:07 -0000       1.548
+++ lib/ChangeLog       8 Sep 2003 00:40:18 -0000
@@ -1,3 +1,9 @@
+2003-09-07  Paul Eggert  <address@hidden>
+
+       * time_r.c (gmtime_r, localtime_r): Fix silly typo: missing arg to
+       copy_tm_result.  Bug reported by Simon Josefsson in
+       <http://mail.gnu.org/archive/html/bug-gnulib/2003-09/msg00028.html>.
+
 2003-09-06  Paul Eggert  <address@hidden>
 
        * time_r.c, time_r.h: New files.
Index: lib/time_r.c
===================================================================
RCS file: /cvsroot/gnulib/gnulib/lib/time_r.c,v
retrieving revision 1.1
diff -p -u -r1.1 time_r.c
--- lib/time_r.c        6 Sep 2003 21:34:07 -0000       1.1
+++ lib/time_r.c        8 Sep 2003 00:40:19 -0000
@@ -59,11 +59,11 @@ ctime_r (time_t const *t, char *buf)
 struct tm *
 gmtime_r (time_t const * restrict t, struct tm * restrict tp)
 {
-  return copy_tm_result (gmtime (t));
+  return copy_tm_result (tp, gmtime (t));
 }
 
 struct tm *
 localtime_r (time_t const * restrict t, struct tm * restrict tp)
 {
-  return copy_tm_result (localtime (t));
+  return copy_tm_result (tp, localtime (t));
 }
Index: modules/time_r
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/time_r,v
retrieving revision 1.1
diff -p -u -r1.1 time_r
--- modules/time_r      6 Sep 2003 21:34:07 -0000       1.1
+++ modules/time_r      8 Sep 2003 00:40:20 -0000
@@ -8,6 +8,7 @@ m4/time_r.m4
 
 Depends-on:
 extensions
+restrict
 
 configure.ac:
 gl_TIME_R