[Bug-gnulib] linebuffer.c bug

[Simon Josefsson]

Should the 'struct linebuffer *' be allocated by the application or by
linebuffer.c?  Right now the code free the pointer, but it never
allocate it, which seems like a bad idea.

Also, it may be good to document that readlinebuffer() never return
anything other than NULL or the input linebuffer parameter, since this
can simply the application code (i.e., 'while (readlinebuffer (lb,
fh))' instead of 'while ((lb = readlinebuffer (lb, fh)))').

void
initbuffer (struct linebuffer *linebuffer)
{
  linebuffer->length = 0;
  linebuffer->size = 200;
  linebuffer->buffer = xmalloc (linebuffer->size);
}

...

void
freebuffer (struct linebuffer *linebuffer)
{
  free (linebuffer->buffer);
  free (linebuffer);
}